Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liballoc extend use intra doc link #75729

Closed
wants to merge 1 commit into from
Closed

Liballoc extend use intra doc link #75729

wants to merge 1 commit into from

Conversation

pickfire
Copy link
Contributor

r? @jyn514

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2020
jyn514
jyn514 reviewed Aug 20, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break because extend is an associated function, not a free function. It can't be fixed with Vec::extend until #74489 is merged, you'd have to use Extend::extend. So I think it would be more clear to wait until we can use Vec::extend.

@pickfire pickfire closed this Aug 20, 2020
@pickfire pickfire deleted the patch-3 branch August 20, 2020 06:49
@jyn514
Copy link
Member

jyn514 commented Aug 28, 2020

@pickfire this can be reopened now that the beta compiler was bumped :)

@jyn514 jyn514 added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@jyn514 jyn514

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pickfire @jyn514 @rust-highfive